Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit on shift+enter fails for async completion #33823

Closed
sharwell opened this issue Mar 2, 2019 · 1 comment
Closed

Commit on shift+enter fails for async completion #33823

sharwell opened this issue Mar 2, 2019 · 1 comment
Assignees
@sharwell
Labels
Area-IDE Disabled Test Integration-Test Test failures in roslyn-integration-CI Regression Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
16.0

Comments

@sharwell
Copy link
Member

sharwell commented Mar 2, 2019

Version Used: 2773f5e

Caught by integration test CommitOnShiftEnter.
@sharwell sharwell added Area-IDE Disabled Test Integration-Test Test failures in roslyn-integration-CI labels Mar 2, 2019
@sharwell sharwell added this to the 16.0 milestone Mar 2, 2019
sharwell added a commit to sharwell/roslyn that referenced this issue Mar 2, 2019
@sharwell
Add an automatic line ender integration test for suggestion mode
f7dcfec 
See dotnet#33823
@sharwell sharwell mentioned this issue Mar 2, 2019
Merged
@sharwell sharwell mentioned this issue Mar 2, 2019
Merged
@sharwell sharwell added the 4 - In Review A fix for the issue is submitted for review. label Mar 2, 2019
@sharwell sharwell self-assigned this Mar 2, 2019
sharwell added a commit to sharwell/roslyn that referenced this issue Mar 3, 2019
@sharwell
Restore original behavior of Shift+Enter during completion
afcedeb 
Fixes dotnet#33823
@ivanbasov ivanbasov mentioned this issue Mar 5, 2019
Closed
@jinujoseph
Copy link
Contributor

resolved via #33828

@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Disabled Test Integration-Test Test failures in roslyn-integration-CI Regression Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
2 participants
@sharwell @jinujoseph