Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalize FlushAsync taking a CancellationToken in net8.0 #71580

Closed
jaredpar opened this issue Jan 11, 2024 · 0 comments · Fixed by #71737
Closed

Rationalize FlushAsync taking a CancellationToken in net8.0 #71580

jaredpar opened this issue Jan 11, 2024 · 0 comments · Fixed by #71737
Assignees
@jasonmalinowski
Labels
Area-IDE

Comments

@jaredpar
Copy link
Member

In net8.0 the TextWriter.FlushAsync() method has an overload that takes a CancellationToken. That is triggering a CA2016 warning that needs to be rationalized.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 11, 2024
@jaredpar jaredpar mentioned this issue Jan 11, 2024
Merged
@jasonmalinowski jasonmalinowski added Area-IDE and removed Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 18, 2024
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Jan 20, 2024
@jasonmalinowski
Ensure we don't leak the request info if a request is cancelled
9bb45d5 
Our trivial RPC system used for the BuildHost only allows a request
to be cancelled before it's sent along the wire -- once it's sent
across then it's sent for good. But if it was cancelled, we didn't clean
up the tracking for it.

This was noticed while looking at a change that was potentially adding
a cancellation token to the FlushAsync call (which is new in .NET 8.0)
and generally ensuring we are explicit with our behavior there.

Closes dotnet#71580
@jasonmalinowski jasonmalinowski mentioned this issue Jan 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure we don't leak the request info if a request is cancelled jasonmalinowski/roslyn
2 participants
@jaredpar @jasonmalinowski