Fix three .editorconfig bugs #35621
Merged
Fix three .editorconfig bugs #35621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any way to test this? |
|
@CyrusNajmabadi Yeah, I'll add a test, at least for the first one. I just wanted this off my machine before I close it for the night. :-) |
|
Thanks! :) |
|
Thank you for asking; good to always keep people honest! |
8 tasks
mavasani
approved these changes
May 10, 2019
jasonmalinowski
changed the title
We have a function that returns all TextDocumentStates held by a ProjectState so we can process updating file names for all files when we add and remove an entire project. This needed updating for AnalyzerConfigDocuments.
Without this, the AnalyzerOptions we get from a Project that does support AnalyzerConfig settings won't be used when running IDE analyzers.
jasonmalinowski
force-pushed
the
fix-editorconfig-bugs
branch
from
bab2272 to
0b757ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These make the full end-to-end experience work.