Semantic snippets - Turn on experiment + turn off old snippets while new snippet experience is on #63991
Conversation
| @@ -30,6 +31,14 @@ namespace Microsoft.CodeAnalysis.CSharp.Completion.Providers | |||
| [Shared] | |||
| internal sealed class SnippetCompletionProvider : LSPCompletionProvider | |||
| { | |||
| private static readonly HashSet<string> s_builtInSnippets = new() | |||
There was a problem hiding this comment.
Are those all the built-in "old" snippets from VS? Do we have a replacement for each one of them?
I guess my question is how was this list created? Are those old "built-in" snippets that semantic snippets replace?
There was a problem hiding this comment.
This is a complete list built-in snippets that I got from the SnippetInfoService. The idea is to replace all of these with semantic snippets but I am turning them all off even if I don't have a replacement so as to not conflate the two experiences.
There was a problem hiding this comment.
If we are going after all of them, consider filtering with their file path instead of maintain a list. For example, if you go to [VS folder]\VC#\Snippets\1033 there seems to have more snippets (although I'm not sure if they are all valid).
There was a problem hiding this comment.
👍 to what @genlu said. We control what and where these onld snippets live so we can change them to make them easier to detect if necessary
ghost
added this to the 
No description provided.