Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ILocalSymbol.IsForEach and IsUsing #64004

Merged
merged 10 commits into from
Sep 19, 2022
Merged

Add ILocalSymbol.IsForEach and IsUsing #64004

merged 10 commits into from
Sep 19, 2022

Conversation

jjonescz
Copy link
Member

Resolves #59709.

@jjonescz jjonescz marked this pull request as ready for review September 14, 2022 10:35
@jjonescz jjonescz requested review from a team as code owners September 14, 2022 10:35
333fred
333fred reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done review pass (commit 1)

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 4)

@runfoapp runfoapp bot mentioned this pull request Sep 15, 2022
Closed
AlekseyTs
AlekseyTs approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 8), with minor comments and assuming that CI is passing. Please squash commits while merging this PR.

@jjonescz
Copy link
Member Author

@AlekseyTs Do I need second approval again after the new changes?

@AlekseyTs
Copy link
Contributor

Do I need second approval again after the new changes?

It looks like @cston has additional comments

@jjonescz jjonescz merged commit c0fa88f into dotnet:main Sep 19, 2022
@jjonescz jjonescz deleted the readonly-localsymbol branch September 19, 2022 15:34
@ghost ghost added this to the Next milestone Sep 19, 2022
@allisonchou allisonchou mentioned this pull request Sep 20, 2022
Closed
@Cosifne Cosifne modified the milestones: Next, 17.4 P3 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar left review comments

@333fred 333fred 333fred left review comments

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Extensions: ILocalSymbol.IsReadOnly
6 participants
@jjonescz @AlekseyTs @jaredpar @333fred @cston @Cosifne