Enforce new grammar rules that scoped keyword must be immediately followed by a type possibly “prefixed” by ref/ref readonly/in/out.
#64088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollowed by a type possibly “prefixed” by `ref`/`ref readonly`/`in`/`out`. Related to dotnet#62039. See also https://github.com/dotnet/csharplang/blob/main/meetings/2022/LDM-2022-07-27.md and https://github.com/dotnet/csharplang/blob/main/proposals/low-level-struct-improvements.md#syntax
|
@cston, @dotnet/roslyn-compiler Please review |
1 similar comment
|
@cston, @dotnet/roslyn-compiler Please review |
cston
reviewed
Sep 19, 2022
| { | ||
| if (this.CurrentToken.ContextualKind == SyntaxKind.ScopedKeyword) | ||
| if (this.CurrentToken.Kind is SyntaxKind.RefKeyword or SyntaxKind.OutKeyword or SyntaxKind.InKeyword) |
There was a problem hiding this comment.
or SyntaxKind.ReadOnlyKeywordperhaps?
That is not needed for any valid scenario. And it is really questionable if that would add any value for an error scenario. Going as is for now.
cston
approved these changes
Sep 19, 2022
|
https://github.com/orgs/dotnet/teams/roslyn-compiler For the second review |
|
@dotnet/roslyn-compiler For the second review |
RikkiGibson
approved these changes
Sep 19, 2022
| @@ -9827,6 +9845,14 @@ private StatementSyntax ParseLocalDeclarationStatement(SyntaxList<AttributeListS | |||
| var variables = _pool.AllocateSeparated<VariableDeclaratorSyntax>(); | |||
| try | |||
| { | |||
| SyntaxToken scopedKeyword = ParsePossibleScopedKeyword(isFunctionPointerParameter: false); | |||
|
|
|||
| // For local functions, 'scoped' is a modifier in LocalFunctionStatementSyntax | |||
There was a problem hiding this comment.
Is an error reported if a local function has the scoped modifier? #Resolved
There was a problem hiding this comment.
Is an error reported if a local function has the scoped modifier?
Yes. There is a test for that. ReturnTypeScope in RefFieldTest.cs, for example.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #62039.
See also https://github.com/dotnet/csharplang/blob/main/meetings/2022/LDM-2022-07-27.md and https://github.com/dotnet/csharplang/blob/main/proposals/low-level-struct-improvements.md#syntax