Use pattern matching for multi-kind checks #64108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
suggested changes
Sep 17, 2022
|
I have never once seen a single trace demonstrating that this matters in practice. Regardless, these methods were not created for perf, they were created to make it more pleasant to do checks way back before we had basic language features for this. |
|
ping @dotnet/roslyn-ide thanks! |
akhera99
approved these changes
Sep 19, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These extensions existed prior to the language having pattern matching. Now that we have that lang facility there isn't a need for it and we can use the more idiomatic built in mechanism.