Move test RSP to artifacts directory #64124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves our generated vstest RSP files into the tmp folder under artifacts. Previously they were being dropped into the root which was causing them to show up in `git status` calls. closes dotnet#63779
|
@dotnet/roslyn-infrastructure PTAL |
RikkiGibson
approved these changes
Sep 19, 2022
genlu
changed the title
genlu
approved these changes
Sep 19, 2022
dibarbet
reviewed
Sep 19, 2022
| string getRspDirectory() | ||
| { | ||
| // There is no artifacts directory on Helix, just use the current directory | ||
| if (options.UseHelix) |
There was a problem hiding this comment.
RunTestAsyncInternal should never get called with options.UseHelix, so not necessary.
dibarbet
approved these changes
Sep 19, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves our generated vstest RSP files into the tmp folder under artifacts. Previously they were being dropped into the root which was causing them to show up in
git statuscalls.closes #63779