Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SymbolAnnotation static #65829

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 7, 2022

Noticed while going through the code that this class isn't intended to be instantiated. All members in it are static, so it can be too.

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 7, 2022 09:29
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 7, 2022
@Youssef1313
Copy link
Member Author

@CyrusNajmabadi Can we get this PR merged please? Thank you

@Youssef1313
Copy link
Member Author

@CyrusNajmabadi Could you restart the failing job please? Thank you

@CyrusNajmabadi CyrusNajmabadi merged commit 7937c02 into dotnet:main Dec 2, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 2, 2024
@Youssef1313 Youssef1313 deleted the patch-41 branch December 2, 2024 05:33
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants