Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use raw strings in EditorFeatures tests #69729

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Use raw strings in EditorFeatures tests #69729

merged 3 commits into from
Aug 30, 2023

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 26, 2023 03:25
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 26, 2023
@CyrusNajmabadi
Cleanup extensions
09dc466 
Use raw strings

Revert
CyrusNajmabadi
CyrusNajmabadi commented Aug 26, 2023
View reviewed changes
...itorFeatures/CSharpTest/AddMissingImports/CSharpAddMissingImportsRefactoringProviderTests.cs
@@ -63,281 +63,281 @@ protected override void InitializeWorkspace(TestWorkspace workspace, TestParamet
[WpfFact]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view with whitespace off.

tmat
tmat requested changes Aug 26, 2023
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert changes in EditAndContinue tests?

This would produce a lot of conflicts with my work in progress. We can apply the refactoring later.

@CyrusNajmabadi
Copy link
Member Author

Yup. Happy to.

@CyrusNajmabadi CyrusNajmabadi requested a review from tmat August 29, 2023 23:46
@CyrusNajmabadi
Copy link
Member Author

@tmat enc changes reverted.

@CyrusNajmabadi CyrusNajmabadi merged commit 94b37d1 into dotnet:main Aug 30, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the extensionCleanup branch August 30, 2023 03:32
@ghost ghost added this to the Next milestone Aug 30, 2023
@allisonchou allisonchou mentioned this pull request Sep 5, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @tmat @Cosifne