Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enc: Clean up SemanticEdit #70449

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Enc: Clean up SemanticEdit #70449

merged 5 commits into from
Nov 13, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 19, 2023 •
edited
Loading

Remove superfluous preserveLocalVariables parameter -- whether or not to preserve local variables is determined by presence of SyntaxMap.

Replace asserts with throws, to fail fast rather than later in the compiler.

Contributes to #70450

TODO:

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 19, 2023
@tmat tmat force-pushed the PreserveLocalVariables branch 2 times, most recently from 4d3cdf5 to 482057b Compare October 19, 2023 16:05
@tmat tmat changed the title Remove unused SemanticEdit parameter: preserveLocalVariables Enc: Clean up SemanticEdit Oct 19, 2023
This was referenced Oct 19, 2023
Closed
Closed
Closed
Closed
Closed
Open
@tmat tmat force-pushed the PreserveLocalVariables branch from 1a8db7a to 6b7a322 Compare October 20, 2023 16:03
@tmat tmat marked this pull request as ready for review October 20, 2023 16:03
@tmat tmat requested review from a team as code owners October 20, 2023 16:03
@tmat tmat mentioned this pull request Oct 24, 2023
Closed
@tmat tmat force-pushed the PreserveLocalVariables branch from d0dbed7 to 129fea9 Compare November 11, 2023 01:00
@tmat tmat enabled auto-merge (squash) November 11, 2023 01:08
@tmat tmat disabled auto-merge November 12, 2023 18:52
@tmat
Copy link
Member Author

tmat commented Nov 12, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Nov 12, 2023
Open
3 tasks
@tmat tmat merged commit 782b8cf into dotnet:main Nov 13, 2023
@tmat tmat deleted the PreserveLocalVariables branch November 13, 2023 03:12
@ghost ghost added this to the Next milestone Nov 13, 2023
@allisonchou allisonchou mentioned this pull request Nov 17, 2023
Closed
@commit-lint commit-lint bot mentioned this pull request Nov 20, 2023
Open
@RikkiGibson RikkiGibson modified the milestones: Next, 17.9 P2 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjonescz jjonescz jjonescz approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Interactive-EnC untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.9 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @jjonescz @cston @RikkiGibson