Use Microsoft.VisualStudio.Sdk meta-package and clean up versions and package references #71111

tmat · 2023-12-05T23:57:28Z

For now, uses Microsoft.VisualStudio.Sdk 17.9.35796-preview.1 as Integration Test machines currently have 17.9 Preview 1.

Switch to Central Package Versioning.

Fixes source build.

Virtual Mono-repo build only reports a few warnings with this change:

/vmr/dotnet/src/roslyn/artifacts/sb/package-cache/system.collections.immutable/9.0.0-alpha.1.24061.26/buildTransitive/netcoreapp2.0/System.Collections.Immutable.targets(4,5): warning : System.Collections.Immutable 9.0.0-alpha.1.24061.26 doesn't support net8.0 and has not been tested with it. Consider upgrading your TargetFramework to net9.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [/vmr/dotnet/src/roslyn/artifacts/sb/src/src/CodeStyle/Tools/CodeStyleConfigFileGenerator.csproj]
/vmr/dotnet/src/roslyn/artifacts/sb/package-cache/system.reflection.metadata/9.0.0-alpha.1.24061.26/buildTransitive/netcoreapp2.0/System.Reflection.Metadata.targets(4,5): warning : System.Reflection.Metadata 9.0.0-alpha.1.24061.26 doesn't support net8.0 and has not been tested with it. Consider upgrading your TargetFramework to net9.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [/vmr/dotnet/src/roslyn/artifacts/sb/src/src/CodeStyle/Tools/CodeStyleConfigFileGenerator.csproj]
/vmr/dotnet/src/roslyn/artifacts/sb/package-cache/system.collections.immutable/9.0.0-alpha.1.24061.26/buildTransitive/netcoreapp2.0/System.Collections.Immutable.targets(4,5): warning : System.Collections.Immutable 9.0.0-alpha.1.24061.26 doesn't support net8.0 and has not been tested with it. Consider upgrading your TargetFramework to net9.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [/vmr/dotnet/src/roslyn/artifacts/sb/src/src/CodeStyle/Tools/CodeStyleConfigFileGenerator.csproj]
/vmr/dotnet/src/roslyn/artifacts/sb/package-cache/system.reflection.metadata/9.0.0-alpha.1.24061.26/buildTransitive/netcoreapp2.0/System.Reflection.Metadata.targets(4,5): warning : System.Reflection.Metadata 9.0.0-alpha.1.24061.26 doesn't support net8.0 and has not been tested with it. Consider upgrading your TargetFramework to net9.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [/vmr/dotnet/src/roslyn/artifacts/sb/src/src/CodeStyle/Tools/CodeStyleConfigFileGenerator.csproj]
        4 Warning(s)
        0 Error(s)

tmat · 2023-12-22T01:00:36Z

@jasonmalinowski @sharwell @dotnet/roslyn-ide PTAL

src/VisualStudio/Core/Test/Utilities/VsNavInfoHelpers.vb

sharwell

Not quite sure how to verify this overall. Moving to Central Package Versioning seems essential for this to work out.

eng/targets/Settings.props

src/EditorFeatures/Core/NavigationBar/NavigationBarController_ModelComputation.cs

src/EditorFeatures/Core/Tagging/AbstractAsynchronousTaggerProvider.TagSource_ProduceTags.cs

src/EditorFeatures/Core/Workspaces/ITextBufferVisibilityTracker.cs

tmat · 2023-12-22T21:54:17Z

Not quite sure how to verify this overall. Moving to Central Package Versioning seems essential for this to work out.

Will follow up on that.

eng/generate-vssdk-versions.csx

src/Compilers/Core/MSBuildTaskTests/Microsoft.Build.Tasks.CodeAnalysis.UnitTests.csproj

genlu · 2024-01-06T00:16:57Z

Switch to Central Package Versioning.

Does this mean we don't have to deal with the version conflicts between the transitive dependency of some package from multiple references anymore?

eng/Directory.Packages.props

eng/targets/Settings.props

tmat · 2024-01-06T01:28:57Z

Does this mean we don't have to deal with the version conflicts between the transitive dependency of some package from multiple references anymore?

Yeah, we shouldn't be.

jaredpar · 2024-01-08T19:50:47Z

How does central package versioning help out with the conflicts? Or why did we want to include it in this change?

I'm not against the change but I wanted to understand a bit better the motivations for moving to it.

jaredpar · 2024-01-16T23:19:17Z

src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/SymbolInfoExtensions.cs


        public static ISymbol? GetAnySymbol(this SymbolInfo info)
            => info.Symbol ?? info.CandidateSymbols.FirstOrDefault();

        public static ImmutableArray<ISymbol> GetBestOrAllSymbols(this SymbolInfo info)
        {
            if (info.Symbol != null)
-                return [info.Symbol];
+                return ImmutableArray.Create(info.Symbol);


Why did we need to undo collection expressions here?

Not 100% sure. Source build was failing.

The source build in CI or the full source build?

eng/targets/Settings.props

tmat · 2024-01-17T04:30:52Z

@tmat FYI, something is wrong with the integration tests on this PR - its finishing in ~5minutes https://dev.azure.com/dnceng-public/public/_build/results?buildId=529108&view=results

Fixed.

…kage Management

ericstj · 2024-01-23T01:26:46Z

sourcebuild.binlog

@tmat - probably this was an accident?

dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 5, 2023

tmat force-pushed the Dependencies branch from e256a71 to 4c4f58b Compare December 11, 2023 22:06

tmat mentioned this pull request Dec 13, 2023

Check Frame's VSFPROPID_IsDocDataInitialized before Getting DocData #71102

Merged

tmat force-pushed the Dependencies branch 2 times, most recently from 4365383 to dbcbe8c Compare December 14, 2023 17:49

build-analysis bot mentioned this pull request Dec 14, 2023

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open

3 tasks

tmat force-pushed the Dependencies branch from dbcbe8c to e9416e9 Compare December 20, 2023 23:02

tmat changed the title ~~Use Microsoft.VisualStudio.Sdk meta-package and clean up versions and…~~ Use Microsoft.VisualStudio.Sdk meta-package and clean up versions and package references Dec 22, 2023

tmat marked this pull request as ready for review December 22, 2023 01:00

tmat requested review from a team as code owners December 22, 2023 01:00

tmat commented Dec 22, 2023

View reviewed changes

src/VisualStudio/Core/Test/Utilities/VsNavInfoHelpers.vb Show resolved Hide resolved

sharwell reviewed Dec 22, 2023

View reviewed changes

tmat force-pushed the Dependencies branch from 519bc2f to 88a4433 Compare January 3, 2024 01:54

jaredpar reviewed Jan 3, 2024

View reviewed changes

eng/generate-vssdk-versions.csx Outdated Show resolved Hide resolved

src/Compilers/Core/MSBuildTaskTests/Microsoft.Build.Tasks.CodeAnalysis.UnitTests.csproj Outdated Show resolved Hide resolved

tmat requested a review from a team as a code owner January 4, 2024 22:08

tmat force-pushed the Dependencies branch 2 times, most recently from 4b30a93 to 6d86c9e Compare January 5, 2024 02:40

genlu reviewed Jan 6, 2024

View reviewed changes

eng/Directory.Packages.props Outdated Show resolved Hide resolved

genlu reviewed Jan 6, 2024

View reviewed changes

eng/targets/Settings.props Show resolved Hide resolved

tmat force-pushed the Dependencies branch from eeff04c to 9589fd2 Compare January 16, 2024 20:23

jaredpar self-assigned this Jan 16, 2024

jaredpar approved these changes Jan 16, 2024

View reviewed changes

tmat force-pushed the Dependencies branch from 9589fd2 to 00c87bb Compare January 17, 2024 01:46

tmat added 12 commits January 17, 2024 15:43

Use Microsoft.VisualStudio.Sdk meta-package and switch to Central Pac…

a5009e0

…kage Management

Update compiler toolset

d906ee3

Fixes

32d1156

Source build

0c8155b

Update prebuilts

35c05e6

Fix

c918912

Avoid ImmutableArray collection expressions

cc9748b

Fix source build TFM in Microsoft.CodeAnalysis.Workspaces.MSBuild.csproj

3a2167d

Feedback

9521143

VS tests

4a5648b

Update VS Editor version

a541257

Fix sqlite test

d218ef7

tmat force-pushed the Dependencies branch from 1708ea6 to 3a98c29 Compare January 17, 2024 23:47

xunit warnings for benchmarks

8c4234c

tmat force-pushed the Dependencies branch from 3a98c29 to 8c4234c Compare January 18, 2024 00:36

ServiceHub

12b7d4a

tmat enabled auto-merge (squash) January 18, 2024 04:18

tmat merged commit db94f71 into dotnet:main Jan 18, 2024
31 checks passed

ghost added this to the Next milestone Jan 18, 2024

tmat deleted the Dependencies branch January 18, 2024 05:38

ericstj reviewed Jan 23, 2024

View reviewed changes

sourcebuild.binlog

Copy link

Member

ericstj Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmat - probably this was an accident?

Cosifne modified the milestones: Next, 17.10 P1 Jan 30, 2024

This was referenced Feb 13, 2024

Poison leak from dotnet tools dotnet/source-build#4116

Closed

Microsoft.Bcl.AsyncInterfaces included in output of dotnet-format dotnet/source-build#4118

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Microsoft.VisualStudio.Sdk meta-package and clean up versions and package references #71111

Use Microsoft.VisualStudio.Sdk meta-package and clean up versions and package references #71111

tmat commented Dec 5, 2023 •

edited

Loading

tmat commented Dec 22, 2023

sharwell left a comment •

edited

Loading

tmat commented Dec 22, 2023

genlu commented Jan 6, 2024

tmat commented Jan 6, 2024

jaredpar commented Jan 8, 2024

jaredpar Jan 16, 2024

tmat Jan 17, 2024

jaredpar Jan 17, 2024

tmat Jan 17, 2024

tmat commented Jan 17, 2024

ericstj Jan 23, 2024

Use Microsoft.VisualStudio.Sdk meta-package and clean up versions and package references #71111

Use Microsoft.VisualStudio.Sdk meta-package and clean up versions and package references #71111

Conversation

tmat commented Dec 5, 2023 • edited Loading

tmat commented Dec 22, 2023

sharwell left a comment • edited Loading

Choose a reason for hiding this comment

tmat commented Dec 22, 2023

genlu commented Jan 6, 2024

tmat commented Jan 6, 2024

jaredpar commented Jan 8, 2024

jaredpar Jan 16, 2024

Choose a reason for hiding this comment

tmat Jan 17, 2024

Choose a reason for hiding this comment

jaredpar Jan 17, 2024

Choose a reason for hiding this comment

tmat Jan 17, 2024

Choose a reason for hiding this comment

tmat commented Jan 17, 2024

ericstj Jan 23, 2024

Choose a reason for hiding this comment

tmat commented Dec 5, 2023 •

edited

Loading

sharwell left a comment •

edited

Loading