Remove "is final document state" from compilation trackers. #72045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@jasonmalinowski this is ready for review. |
|
@jasonmalinowski @ToddGrun ptal. |
|
Merging in. But would still like a review from @jasonmalinowski . |
ghost
added this to the 
| @@ -732,14 +731,15 @@ async Task<InProgressState> CollapseInProgressStateAsync(InProgressState initial | |||
|
|
|||
| // We will finalize the compilation by adding full contents here. | |||
| var (compilationWithGeneratedDocuments, generatedDocuments, generatorDriver) = await AddExistingOrComputeNewGeneratorInfoAsync( | |||
| isFrozen, | |||
| compilationState, | |||
| compilationWithoutGeneratedDocuments, | |||
| generatorInfo, | |||
| staleCompilationWithGeneratedDocuments, | |||
| cancellationToken).ConfigureAwait(false); | |||
|
|
|||
| // After producing the sg documents, we must always be in the final state for the generator data. | |||
There was a problem hiding this comment.
Comment is stale (kinda).
|
This looked good @CyrusNajmabadi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea made by @jasonmalinowski in prior prs. Followup to #72021