Add dedicated bit for indicating if a node itself has annotations (versus its children). #72104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsus its children).
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
commented
Feb 15, 2024
| System.Diagnostics.Debug.Assert(annotations.Length != 0, "we should return nonempty annotations or NoAnnotations"); | ||
| return annotations; | ||
| } | ||
| } |
There was a problem hiding this comment.
this is the meat of the change. In the past, we'd end up lookign at nodes that didn't actually have annotations on htem, because they had a child somewhere deep under them with annotations. This was very expensive as CWT lookups are not cheap. For tree rewrites, when rewriting nodes , we look at the old node to copy annotations over. And this meant almost always doing this work just if a deep child token had an annotation. now we only need to do the work on nodes that actually have annotations on them themselves.
|
@RikkiGibson @sharwell @333fred this is ready for review. |
RikkiGibson
approved these changes
Feb 15, 2024
RikkiGibson
approved these changes
Feb 15, 2024
sharwell
approved these changes
Feb 15, 2024
333fred
approved these changes
Feb 15, 2024
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #72070. Draft while that is in review.
This helps avoid expensive conditionalweaktable lookups. This is especially useful when examining trees for things like elastic trivia. We end up seeing that some child has annotations deep in a node. But we need to examine all the nodes down to the child to see if they have annotations on them (since we can't distinguish 'has' vs 'contains'). For large trees, where all the tokens have elastic trivia, this is incredibly expensive.