Make method abstract and force subclasses to implement #72145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Feb 16, 2024
| @@ -5,43 +5,39 @@ | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
|
|
|||
| namespace Microsoft.CodeAnalysis | |||
| namespace Microsoft.CodeAnalysis; | |||
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Feb 16, 2024
| { | ||
| public abstract Task<Compilation> TransformCompilationAsync(Compilation oldCompilation, CancellationToken cancellationToken); |
There was a problem hiding this comment.
i far preferred subclasses having to be intentional about what they should do here. i already did something similar for CanUpdateCompilationWithStaleGeneratedTreesIfGeneratorsGiveSameOutput previously.
There was a problem hiding this comment.
now, the only non-abstract method is TryMergeWithPrior. And that one is fine to stay virtual as it's only used as a perf optimization, not a correctness one.
CyrusNajmabadi
commented
Feb 16, 2024
.../Solution/SolutionCompilationState.CompilationAndGeneratorDriverTranslationAction_Actions.cs
Outdated
Show resolved
Hide resolved
…ationState.CompilationAndGeneratorDriverTranslationAction_Actions.cs
CyrusNajmabadi
commented
Feb 16, 2024
| public override bool CanUpdateCompilationWithStaleGeneratedTreesIfGeneratorsGiveSameOutput => true; | ||
|
|
||
| public override Task<Compilation> TransformCompilationAsync(Compilation oldCompilation, CancellationToken cancellationToken) |
There was a problem hiding this comment.
for cases where there was an existing comment explaining things, i didn't comment.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.