Fix crash in designer discovery #72151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
approved these changes
Feb 16, 2024
src/VisualStudio/Core/Def/DesignerAttribute/VisualStudioDesignerAttributeService.cs
Outdated
Show resolved
Hide resolved
arunchndr
approved these changes
Feb 16, 2024
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed with #71999 because we changed the logic from: "sync solution (which only syncs C#/VB projects), then process whole solution on remote site" to "first, attempt to analyze the active document, then do the original full-sync and analyze". However, the code to analyze the active document was invalid for the case of this not being a C#/VB file. IN that case, we'd sync over the C#/VB subset of projects, then not find the non-C#/VB file on the oop side, immediately crashing.