Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsoleted constructor #72194

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Remove obsoleted constructor #72194

merged 2 commits into from
Feb 21, 2024

Conversation

CyrusNajmabadi
Copy link
Member

This constructor was obsoleted last march (with an error). It can be removed now.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner February 20, 2024 23:56
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 20, 2024
ToddGrun
ToddGrun approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 6710a60 into dotnet:main Feb 21, 2024
27 checks passed
@ghost ghost added this to the Next milestone Feb 21, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the removeLegacyConstructor branch February 21, 2024 07:00
@jjonescz jjonescz modified the milestones: Next, 17.10 P2 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @jjonescz