Move all the MSBuildWorkspace projects under a single folder #72226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
commented
Feb 22, 2024
| <TargetFrameworks>$(NetRoslyn);net472</TargetFrameworks> | ||
| </PropertyGroup> | ||
| <ItemGroup Label="Project References"> | ||
| <ProjectReference Include="..\..\..\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj" /> |
There was a problem hiding this comment.
This is also a move, but since every one of these got a .. put in front of it, Git sees it as a new file.
JoeRobich
approved these changes
Feb 22, 2024
jasonmalinowski
commented
Feb 22, 2024
| @@ -1,14 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm not sure why this got deleted, but these don't work anyways, so...
3 tasks
Now there's MSBuildWorkspace with three folders: - Core (the main library) - BuildHost - Test
jasonmalinowski
force-pushed
the
moving-msbuild-folders
branch
from
bfc2d3b to
d53d903
Compare
The tests that need to set things up like this should just be ensuring this state directly, since there's no guarantee that this would have ran before many types of tests run. Fixes dotnet#49486
jasonmalinowski
force-pushed
the
moving-msbuild-folders
branch
from
d53d903 to
57ddd2f
Compare
JoeRobich
added a commit
that referenced
this pull request
Jan 21, 2025
This is a rework of #72226 Now there's Workspaces/MSBuild with three folders: - Core (the main library) - BuildHost - Test
|
The changes merged as part of #76831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now there's MSBuildWorkspace with three folders: