Defer creating compilations for in-progress-states until actually needed. #72289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Feb 27, 2024
| namespace Microsoft.CodeAnalysis | ||
| namespace Microsoft.CodeAnalysis; | ||
|
|
||
| internal partial class SolutionCompilationState | ||
| { |
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Feb 27, 2024
|
|
||
| #if DEBUG |
There was a problem hiding this comment.
moved down to subclasses as it can't run during hte constructor now as the base types will not have setup CompilationWithoutGeneratedDocuments yet.
ToddGrun
reviewed
Feb 27, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.CompilationTracker.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Feb 27, 2024
| using var _2 = ArrayBuilder<SyntaxTree>.GetInstance(out var alreadyParsedTrees); | ||
| var alreadyParsedCount = this.ProjectState.DocumentStates.States.Count(s => s.Value.TryGetSyntaxTree(out _)); | ||
|
|
||
| using var _1 = ArrayBuilder<DocumentState>.GetInstance(alreadyParsedCount, out var documentsWithTrees); |
There was a problem hiding this comment.
ToddGrun
reviewed
Feb 27, 2024
| @@ -703,15 +703,17 @@ public ICompilationTracker FreezePartialState(CancellationToken cancellationToke | |||
| // parsed documents over to the new project state so we can preserve as much information as | |||
| // possible. | |||
|
|
|||
| using var _1 = ArrayBuilder<DocumentState>.GetInstance(out var documentsWithTrees); | |||
| using var _2 = ArrayBuilder<SyntaxTree>.GetInstance(out var alreadyParsedTrees); | |||
| var alreadyParsedCount = this.ProjectState.DocumentStates.States.Count(s => s.Value.TryGetSyntaxTree(out _)); | |||
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we freeze a solution, it is very common to freeze many projects that then will not have their compilations actually looked at. The current freezing mechanism produces compilations for all these projects no matter what. This is not free, and i've seen the number of compilations (and all the caches they creatE) show up in traces.
This approach moves us to delay actually creating the compilations until the point they are actually needed. This will be never for most projects in a large solution, as the vast majority of features that even freeze the solution in the first place will not even look outside of the projects/compilations in the current project cone.