Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid synthesizing the parameterless struct constructor unnecessarily #72314

Merged
merged 1 commit into from
Feb 28, 2024

Avoid synthesizing the parameterless struct constructor unnecessarily

677d610
Select commit
Loading
Failed to load commit list.
Merged

Avoid synthesizing the parameterless struct constructor unnecessarily #72314

Avoid synthesizing the parameterless struct constructor unnecessarily
677d610
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis succeeded Feb 28, 2024 in 0s

.NET Result Analysis

Details

All checks completed

[roslyn-CI]

Build Rerun

✔️ Build passed after 1 retries.

(Attempt #1) [link to build]

roslyn-CI / Windows_Release_Desktop / Test_Windows_Desktop_Release_32 / Run Unit Tests

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌(NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed
    ❌PowerShell exited with code '1'.

Non-Deterministic Test Failures Detected

Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests_Await.AwaitCompletionAddsAsync_FunctionDeclaration [Console] [Details] [Artifacts] [0.52% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

Failing Configuration

Exception Message
Assert.NotNull() Failure
CallStack
   at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.TestState.VB$StateMachine_50_AssertSelectedCompletionItem.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests_Await.VB$StateMachine_2_AwaitCompletionAddsAsync_FunctionDeclaration.MoveNext() in /_/src/EditorFeatures/Test2/IntelliSense/VisualBasicCompletionCommandHandlerTests_AwaitCompletion.vb:line 85
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests_Await.AwaitCompletionAddsAsync_MultiLineFunctionLambdaExpression_AlreadyAsync [Console] [Details] [Artifacts] [0.52% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

Failing Configuration

Exception Message
Assert.NotNull() Failure
CallStack
   at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.TestState.VB$StateMachine_50_AssertSelectedCompletionItem.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests_Await.VB$StateMachine_10_AwaitCompletionAddsAsync_MultiLineFunctionLambdaExpression_AlreadyAsync.MoveNext() in /_/src/EditorFeatures/Test2/IntelliSense/VisualBasicCompletionCommandHandlerTests_AwaitCompletion.vb:line 319
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests_Await.AwaitCompletionAddsAsync_MultiLineSubLambdaExpression [Console] [Details] [Artifacts] [0.52% failure rate]
[ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

Failing Configuration

Exception Message
Assert.NotNull() Failure
CallStack
   at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.TestState.VB$StateMachine_50_AssertSelectedCompletionItem.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests_Await.VB$StateMachine_5_AwaitCompletionAddsAsync_MultiLineSubLambdaExpression.MoveNext() in /_/src/EditorFeatures/Test2/IntelliSense/VisualBasicCompletionCommandHandlerTests_AwaitCompletion.vb:line 174
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Was this helpful? Yes No