Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local deployment instructions #73417

Merged
merged 2 commits into from
May 14, 2024
Merged

Update local deployment instructions #73417

merged 2 commits into from
May 14, 2024

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented May 9, 2024

If I just do a normal restore, then I get the following error:

C:\repos\roslyn\.dotnet\sdk\8.0.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(396,5): error NETSDK1094: Unable to optimize assemblies for performance: a valid runtime package was not found.
Either set the PublishReadyToRun property to false, or use a supported runtime identifier when publishing. When targeting .NET 6 or higher, make sure to restore packages with the PublishReadyToRun property set
 to true. [C:\repos\roslyn\src\Interactive\HostProcess\x64\InteractiveHost64.csproj::TargetFramework=net8.0-windows]

@jcouv jcouv self-assigned this May 9, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 9, 2024
@jcouv jcouv added Area-Compilers and removed Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 9, 2024
@jcouv jcouv marked this pull request as ready for review May 10, 2024 17:24
@jcouv
Copy link
Member Author

jcouv commented May 10, 2024

@jaredpar @dotnet/roslyn-compiler for review of small doc change. Thanks

jaredpar
jaredpar reviewed May 10, 2024
View reviewed changes
docs/contributing/Building, Debugging, and Testing on Windows.md Outdated
@@ -86,6 +86,7 @@ give it a try.
### Deploying with command-line (recommended method)

You can build and deploy with the following command:
`.\Restore.cmd -Configuration Release` followed by
`.\Build.cmd -Configuration Release -deployExtensions -launch`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`.\Build.cmd -Configuration Release -deployExtensions -launch`.
`.\Build.cmd -Restore -Configuration Release -deployExtensions -launch`.

Why two lines here? This one line should do the same thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better indeed. Thanks

@jcouv jcouv requested a review from jaredpar May 10, 2024 17:47
@jcouv jcouv enabled auto-merge (squash) May 10, 2024 18:24
@jcouv
Copy link
Member Author

jcouv commented May 14, 2024

/azp run

@jcouv jcouv merged commit 2577230 into main May 14, 2024
5 checks passed
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 14, 2024
This was referenced May 16, 2024
Closed
Closed
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Documentation
Projects
None yet
Milestone
17.11 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@jcouv @jaredpar @Cosifne