Update to simple using statements #73632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
simpleUsing
branch
from
3e29648 to
9783a30
Compare
ToddGrun
reviewed
May 22, 2024
| using (var stream = SerializableBytes.CreateWritableStream()) | ||
| using var stream = SerializableBytes.CreateWritableStream(); | ||
| using (var gzipStream = new GZipStream(stream, CompressionLevel.Optimal, leaveOpen: true)) | ||
| using (var writer = new ObjectWriter(gzipStream, leaveOpen: true)) |
There was a problem hiding this comment.
did these two get missed?
ToddGrun
reviewed
May 22, 2024
| @@ -98,10 +98,8 @@ public void TestZeroLengthStreams() | |||
| handle = service.WriteToTemporaryStorage(stream1, CancellationToken.None); | |||
| } | |||
There was a problem hiding this comment.
That would change semantics, moving where the Dispose is called during program execution
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.