Address a few locations also need to care about partial properties #73792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Cosifne
commented
May 30, 2024
| @@ -164,6 +164,34 @@ public partial class C1 | |||
| Assert.Equal(implementation, ResolveSymbol(implementation, comp, SymbolKeyComparison.None)); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void ExtendedPartialPropertyDefinitionAndImplementationResolveCorrectly() | |||
There was a problem hiding this comment.
This is just a test verified the same behavior as partial methods above.
Cosifne
commented
May 30, 2024
| @@ -73,18 +73,27 @@ public CSharpNavigationBarItemService() | |||
| continue; | |||
| } | |||
|
|
|||
| var method = member as IMethodSymbol; | |||
| if (method != null && method.PartialImplementationPart != null) | |||
| if (member is IMethodSymbol { PartialImplementationPart: { } } methodSymbol) | |||
There was a problem hiding this comment.
Without this change, navigation bar still works.
Before:
After:
After behavior matches the existing behavior of partial method.
Cosifne
commented
May 30, 2024
| @@ -227,8 +227,12 @@ private async Task<IEnumerable<INamedTypeSymbol>> GetAllTypesAsync(CancellationT | |||
| return namespaces.GetAllTypes(cancellationToken); | |||
| } | |||
|
|
|||
| private static IMethodSymbol GetPartialImplementationPartOrNull(ISymbol symbol) | |||
| => (symbol.Kind == SymbolKind.Method) ? ((IMethodSymbol)symbol).PartialImplementationPart : null; | |||
| private static ISymbol GetPartialImplementationPartOrNull(ISymbol symbol) => symbol.Kind switch | |||
There was a problem hiding this comment.
cc @tmat to take a look. Not familiar with debugger, but I feel this change brings no harm.
CyrusNajmabadi
approved these changes
May 31, 2024
RikkiGibson
approved these changes
May 31, 2024
Cosifne
merged commit 8b6bdf2
into
dotnet:features/partial-properties
22 of 25 checks passed
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address part of this #73772
So in the IDE part:
This PR add the handling for partial properties for:
roslyn/src/EditorFeatures/CSharpTest/SymbolKey/SymbolKeyCompilationsTests.cs
roslyn/src/Features/Core/Portable/Debugging/AbstractBreakpointResolver.cs
roslyn/src/Features/CSharp/Portable/NavigationBar/CSharpNavigationBarItemService.cs