Add weak heuristics in our designer scanning code to improve experience during things like configuration switch. #74130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
designerAttribute
branch
from
759abe8 to
94a4793
Compare
Update tests Add test NRT
CyrusNajmabadi
force-pushed
the
designerAttribute
branch
from
ebd838b to
8e155e1
Compare
Cosifne
reviewed
Jun 25, 2024
| { | ||
| foreach (var wellKnownNamespace in s_wellKnownDesignerNamespaces) | ||
| { | ||
| var wellKnownType = compilation.GetTypeByMetadataName($"{wellKnownNamespace}.{errorType.Name}"); |
There was a problem hiding this comment.
🤔When will this happen to user? Namespace misspelling, why the namespace in SemanticModel is wrong?
There was a problem hiding this comment.
Basically, as a restore happens, we can lose and then get references again. Also, generators may not run again until we know about them again, so we lost global usings.
This keeps everything still looking good (and usable for the designer side) while we get back into a good state again.
|
Approach is Ok, but I am curious about what's the affected secnario? |
Cosifne
approved these changes
Jun 26, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current approach leads to projects changing their designability, which can break the designer, even though it actually works in these scenarios. By adding a couple of weak heuristics (that we discussed with WinForms designer team) we can be much more robust.
We will likely backport this to 17.10 as well. But getting review in Main first.