Remove GetTempPath copy #74159
Merged
Remove GetTempPath copy #74159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was addedin 2016 when the compiler was still coming to terms with its server process model. At that time we discovered that the return for `Path.GetTempPath()` was different for different invocation of our build task. This happened when more complex builds changed environment variables that influenced temp directories. Part of our reaction was adding this function that gave us more control over how temporary paths could vary between builds. It let us have explicit control over the working directory. In the years since this change was made we've gotten a lot more mature in our model here: 1. `Path.GetTemPath` is banned in the compiler via analyzers 2. The server process model is established and we are much more rigorous with how environment variables, temp paths, etc ... are handled. As such this method serves very little purpose. It just makes our code different and harder to understand. As such we're removing it.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@roslyn-compiler PTAL |
cston
approved these changes
Jun 25, 2024
RikkiGibson
reviewed
Jun 26, 2024
| @@ -520,8 +520,7 @@ internal int ExecuteTool(string pathToTool, string responseFileCommands, string | |||
| var requestId = getRequestId(); | |||
| logger.Log($"Compilation request {requestId}, PathToTool={pathToTool}"); | |||
|
|
|||
| string workingDirectory = CurrentDirectoryToUse(); | |||
| string? tempDirectory = BuildServerConnection.GetTempPath(workingDirectory); | |||
| string? tempDirectory = Path.GetTempPath(); | |||
There was a problem hiding this comment.
So in the case where $env:TEMP is a relative path, is there a need to resolve it against the "CurrentDirectoryToUse()" now?
There was a problem hiding this comment.
No. It's the job of GetTempPath to ensure there is a valid path here.
|
Test jobs appear to be timing out |
RikkiGibson
approved these changes
Jun 26, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was addedin 2016 when the compiler was still coming to terms with its server process model. At that time we discovered that the return for
Path.GetTempPath()was different for different invocation of our build task. This happened when more complex builds changed environment variables that influenced temp directories.Part of our reaction was adding this function that gave us more control over how temporary paths could vary between builds. It let us have explicit control over the working directory.
In the years since this change was made we've gotten a lot more mature in our model here:
Path.GetTemPathis banned in the compiler via analyzersAs such this method serves very little purpose. It just makes our code different and harder to understand. As such we're removing it.