EnumerableConditionalWeakTable and WeakEvent #74160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
...paces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/EnumerableConditionalWeakTable.cs
Outdated
Show resolved
Hide resolved
...paces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/EnumerableConditionalWeakTable.cs
Show resolved
Hide resolved
...paces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/EnumerableConditionalWeakTable.cs
Show resolved
Hide resolved
...paces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/EnumerableConditionalWeakTable.cs
Show resolved
Hide resolved
...paces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/EnumerableConditionalWeakTable.cs
Show resolved
Hide resolved
...paces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/EnumerableConditionalWeakTable.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/WeakEvent`1.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/WeakEvent`1.cs
Outdated
Show resolved
Hide resolved
...paces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/EnumerableConditionalWeakTable.cs
Show resolved
Hide resolved
sharwell
requested changes
Jun 26, 2024
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/WeakEvent`1.cs
Outdated
Show resolved
Hide resolved
3 tasks
CyrusNajmabadi
approved these changes
Jun 27, 2024
sharwell
approved these changes
Jun 28, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of WeakEvent. Separates a concept of enumerable ConditionalWeakTable from WeakEvent implementation. On .NET
EnumerableConditionalWeakTableis just a wrapper forConditionalWeakTableas it is already enumerable. On .NET Framework we need to implement the enumerability.Further, because the subscriber of a WeakEvent does not necessarily hold on the target object of the event, we pass the target object to the handler so that it can conveniently access it. To do that we change the event handler delegate to
WeakEventHandlerthat takes both sender and target (as well as args).Renames existing
WeakEventHandlerstatic class toEventHandlerFactoryto avoid name collision. The existingWeakEventHandlerlogic could potentially be used to achieve the same goal asWeakEventbut it imposes constraints on the delegate target to not capture any state. We do not have an analyzer that enforces such requirement. It would also make the subscribers a bit more complicated to implement.