Improve performance of expensive operation #74247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
Jul 2, 2024
| @@ -48,7 +48,8 @@ internal sealed partial class SolutionState | |||
| public ImmutableDictionary<string, StructuredAnalyzerConfigOptions> FallbackAnalyzerOptions { get; } = ImmutableDictionary<string, StructuredAnalyzerConfigOptions>.Empty; | |||
|
|
|||
| /// <summary> | |||
| /// Number of projects in the solution of the given language. | |||
| /// Number of projects in the solution of the given language. The value is guaranteed to always be greater than zero. | |||
| /// If the project count does ever hit then there simply is no key/value pair for that language in this map. | |||
CyrusNajmabadi
commented
Jul 2, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by dave kean as being super expensive. We walk the entire soluiotn, creating all the red project nodes, just to determine if we have a single C#/VB project. But we already have that info, so just use it directly.