Convert SymbolSearchOptions to editorconfig options #74378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
tmat
changed the title
3 tasks
tmat
force-pushed
the
SymbolSearchOptions
branch
from
70d8272 to
728a2c9
Compare
Open
3 tasks
src/Features/Core/Portable/AddMissingReference/AbstractAddMissingReferenceCodeFixProvider.cs
Show resolved
Hide resolved
src/Features/Core/Portable/AddPackage/AbstractAddPackageCodeFixProvider.cs
Show resolved
Hide resolved
| @@ -46,31 +33,35 @@ internal abstract partial class AbstractAddPackageCodeFixProvider : CodeFixProvi | |||
|
|
|||
| var workspaceServices = document.Project.Solution.Services; | |||
|
|
|||
| var symbolSearchService = _symbolSearchService ?? workspaceServices.GetService<ISymbolSearchService>(); | |||
| var installerService = _packageInstallerService ?? workspaceServices.GetService<IPackageInstallerService>(); | |||
| if (workspaceServices.GetService<ISymbolSearchService>() is not { } symbolSearchService || | |||
There was a problem hiding this comment.
fwiw, i don't like not { } name to mix the retrival and null check. i'd prefer a distinct null check step.
| IPackageInstallerService packageInstallerService = null, | ||
| ISymbolSearchService symbolSearchService = null) | ||
| : base(packageInstallerService, symbolSearchService) | ||
| protected AbstractAddSpecificPackageCodeFixProvider() |
|
|
||
| internal static class SymbolSearchOptionsStorage | ||
| { | ||
| private static readonly OptionGroup s_optionGroup = new(name: "symbol_search", description: FeaturesResources.Symbol_search); |
There was a problem hiding this comment.
maybe dotnet_symbol_search? what's the namign we're generally using for these groups?
There was a problem hiding this comment.
"dotnet" is part of the option name. It ends up as dotnet.symbolSearch.searchReferenceAssemblies in VS Code after the transformations we do.
src/Features/DiagnosticsTestUtilities/CodeActions/CSharpCodeFixVerifier`2+Test.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jul 17, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dotnet_search_reference_assembliesto a supported editorconfig option (used by VS Code) anddotnet_unsupported_search_nuget_packagesto an unsupported one.SymbolSearchOptionswere the last options onCodeActionOptions. Removing the former allows us to remove the latter.