Adjust overload resolution priority from LDM #74428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDM today decided that on older language versions, we shouldn't influence overload resolution from OverloadResolutionPriority. It also decided that we should disallow the attribute on local functions.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
cston
approved these changes
Jul 17, 2024
jcouv
reviewed
Jul 18, 2024
| @@ -1712,10 +1712,15 @@ private int GetTheBestCandidateIndex<TMember>(ArrayBuilder<MemberResolutionResul | |||
| return currentBestIndex; | |||
| } | |||
|
|
|||
| private static void RemoveLowerPriorityMembers<TMemberResolution, TMember>(ArrayBuilder<TMemberResolution> results) | |||
| private void RemoveLowerPriorityMembers<TMemberResolution, TMember>(ArrayBuilder<TMemberResolution> results) | |||
There was a problem hiding this comment.
Let's also incorporate the change into the spec
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDM today decided that on older language versions, we shouldn't influence overload resolution from OverloadResolutionPriority. It also decided that we should disallow the attribute on local functions.