Add optional value to dart-lab yml #74953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jjonescz
reviewed
Aug 30, 2024
| - name: sha | ||
| type: string | ||
| default: '' | ||
| default: 'None' |
There was a problem hiding this comment.
Can the sha parameter be removed? It looks like it's used only in logs.
There was a problem hiding this comment.
Depends on @akhera99 's opinion as she edited these
There was a problem hiding this comment.
It's used with the github comment bot, so the SHA is handy to link back to the specific commit.
akhera99
approved these changes
Sep 10, 2024
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't run dart-lab without commit number and sha. After an optional value should solve the problem.
