Test allocations #75171
Merged
Test allocations #75171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuing to work on unnecessary allocations in our unit tests
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jaredpar
commented
Sep 19, 2024
| @@ -12384,7 +12384,7 @@ void binaryOperator(string op, string leftType, string rightType, string expecte | |||
|
|
|||
| if (expectedDiagnostics.Length == 0) | |||
| { | |||
| CompileAndVerify(comp); | |||
| CompileAndVerify(comp, emitOptions: EmitOptions.Default); | |||
There was a problem hiding this comment.
By default CompileAndVerify embeds portable PDBs and the sheer number of tests here was causing that allocate 100MB of unnecessary byte[].
| @@ -13,6 +13,7 @@ | |||
| using System.IO; | |||
| using System.Linq; | |||
| using System.Reflection; | |||
| using System.Runtime.InteropServices; | |||
There was a problem hiding this comment.
This is a significant source of redundant byte[] allocations.
| /// <summary> | ||
| /// This is the full set of references provided by default on the .NET Framework TFM | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// Need to special case tuples until we move to net472 | ||
| /// </remarks> | ||
| public static ImmutableArray<MetadataReference> References { get; } = [.. Net461.References.All, Net461.ExtraReferences.SystemValueTuple]; | ||
| public static ImmutableArray<MetadataReference> References |
There was a problem hiding this comment.
There are a number of tests that call say NetFramework.mscorlib. When this was a static initializer that realized all these values when they didn't really need to be. This is only a savings in certain silces of our tests but it's a significant one in them.
|
@dotnet/roslyn-compiler PTAL |
AlekseyTs
reviewed
Sep 19, 2024
AlekseyTs
reviewed
Sep 19, 2024
333fred
approved these changes
Sep 19, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to work on unnecessary allocations in our unit tests