Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enc logging #76042

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Enc logging #76042

merged 4 commits into from
Jan 23, 2025

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 22, 2024

Adds support for reporting Roslyn EnC log messages to Hot Reload output pane.

The output pane is populated by debugger's IHotReloadLogger brokered service. We connect to this service directly from Roslyn OOP and send messages to it in addition to writing them to in-memory rolling log.

With verbosity set to diagnostic:
image

Roslyn log messages appear in Hot Reload output pane:
image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2024
@tmat tmat marked this pull request as ready for review January 22, 2025 00:00
@tmat tmat requested a review from a team as a code owner January 22, 2025 00:00
@tmat
Copy link
Member Author

tmat commented Jan 22, 2025

@davidwengier ptal

@tmat tmat enabled auto-merge (squash) January 23, 2025 15:39
@tmat tmat merged commit d5cf1ea into dotnet:main Jan 23, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 23, 2025
@dibarbet dibarbet modified the milestones: Next, 17.14 P1 Jan 28, 2025
333fred added a commit that referenced this pull request Jan 30, 2025
@333fred 333fred mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants