Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'create constructor' with types without bodies #76083

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix 'create constructor' with types without bodies #76083

merged 2 commits into from
Nov 26, 2024

Conversation

CyrusNajmabadi
Copy link
Member

fixes #72340

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 26, 2024 00:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 26, 2024
JoeRobich
JoeRobich reviewed Nov 26, 2024
View reviewed changes
...res/CSharpTest/ConvertPrimaryToRegularConstructor/ConvertPrimaryToRegularConstructorTests.cs

#region constructors

#endregion

public C(int i)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it about calling EnsureOpenAndCloseBraceTokens that caused this constructor to change where it was generated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I should have just looked.

roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/TypeDeclarationSyntaxExtensions.cs

Lines 121 to 124 in 151e2d7

if (!hasMembers)
{
// Bug 539673: If there are no members, take any trivia that
// belongs to the end brace and attach it to the opening brace.

@CyrusNajmabadi CyrusNajmabadi merged commit 9d83aaf into dotnet:main Nov 26, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 26, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the createConstructotr branch November 26, 2024 02:10
@dotnet-bot dotnet-bot mentioned this pull request Nov 29, 2024
Closed
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 29, 2024
Closed
CyrusNajmabadi added a commit that referenced this pull request Dec 2, 2024
@CyrusNajmabadi
Add more tests for #76083 (#76164)
a5eacaf
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

[Bug]: Code fix Convert to regular constructor generates incorrectly for class without body
3 participants
@CyrusNajmabadi @JoeRobich @dibarbet