Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove cast that would change what runtime type a virtual method dispatches to #76102

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #75424

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 26, 2024 17:04
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 26, 2024
@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal

Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 769593d into dotnet:main Nov 26, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 26, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the removeCastVirtual branch November 26, 2024 22:25
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE0004 false positive when using GetType()
3 participants