Fix broken 'convert if to switch' case with recursive analysis #76317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@alrz can you let me know if this meets your expectations here? |
CyrusNajmabadi
commented
Dec 7, 2024
...Core/Portable/ConvertIfToSwitch/AbstractConvertIfToSwitchCodeRefactoringProvider.Analyzer.cs
Outdated
Show resolved
Hide resolved
…ToSwitchCodeRefactoringProvider.Analyzer.cs
alrz
reviewed
Dec 8, 2024
Comment on lines
+117
to
+122
| // If we're in the initial state, it's fine for there to be many operations that follow. We're just | ||
| // trying to check if the first one completes our analysis (and we'll not touch the ones that | ||
| // follow). However, if we're actually in one of the recursive calls, it's *not* ok to ignore the | ||
| // following ops as those may impact if the higher call into us is ok. So in that case, we do not | ||
| // allow the parsing to succeed if we have more than one operation left. | ||
| return topLevel |
There was a problem hiding this comment.
The topLevel distinction makes complete sense. I don't have the mental model on the inner workings of this right now but I might have missed other places where this matters.
JoeRobich
approved these changes
Dec 10, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71295