Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'sort usings' to always preserve the new-lines that were present in the document #76332

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #44136

This ensures that we never do an sort-usings and end up causing 'mixed' lines in the doc when the file doesn't necessarily match things like the editor-config desired line.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 8, 2024 00:44
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 8, 2024
@CyrusNajmabadi
Copy link
Member Author

@JoeRobich @ToddGrun ptal

@CyrusNajmabadi CyrusNajmabadi merged commit 3777d99 into dotnet:main Dec 9, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the organizeUsingsEndOfLine branch December 9, 2024 20:04
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 9, 2024
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditorConfig: ingnoring end_of_line when sort directives or separate import directive groups
3 participants