Remove usage of WaitAndGetResult from debugger paths #76479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoeRobich @jasonmalinowski ptal. |
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
approved these changes
Dec 17, 2024
|
|
||
| var point = nullablePoint.Value; | ||
| var proximityExpressions = await _proximityExpressionsService.GetProximityExpressionsAsync( | ||
| document, point.Position, context.UserCancellationToken).ConfigureAwait(true); |
There was a problem hiding this comment.
There's places you're doing a ConfigureAwait(true) before we return a VsEnumBSTR and also places we you are donig ConfigureAwait(false); for example ResolveName below. I don't imagine we need to be on the UI thread at that point so I think it's fine, but I'd ask that either we make them consistently ConfigureAwait(true) or ConfigureAwait(false).
There was a problem hiding this comment.
Platform guidance is anything known to only be called from a jtf run should be CA(true). That way the main thread can execute those callbacks instead of blocking waiting for a big thread to do it.
CyrusNajmabadi
commented
Dec 17, 2024
src/VisualStudio/Core/Def/LanguageService/AbstractLanguageService`2.VsLanguageDebugInfo.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Dec 17, 2024
src/VisualStudio/Core/Def/LanguageService/AbstractLanguageService`2.VsLanguageDebugInfo.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Dec 17, 2024
src/VisualStudio/Core/Def/LanguageService/AbstractLanguageService`2.VsLanguageDebugInfo.cs
Outdated
Show resolved
Hide resolved
3 tasks
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.