Merge main into features/PartialEventsCtors
#76946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, Microsoft.CodeAnalysis.Workspaces.MSBuild.dll itself is deployed, but will fail to work since it can't find any build hosts deployed alongside the DLL. Fixes dotnet#73854
The number of users this could help is very, very tiny, and the number of ways it could cause further problems is much, much higher.
Options services are added to the LanguageServer project so that the extract refactorings will run. The options use defaults and do not require user interaction. This is part of the O# parity work and the defaults match those used by O#. Once inserted, this will resolve dotnet/vscode-csharp#6430
In VS 17.13, the editor's `IGlyphService` implementation was improved to return images from `IVsImageService2` based on the appropriate moniker. This fixes several instances of blurry 16px icons throughout the IDE. Unfortunately, some WPF components failed to specify explicit `Image` dimensions, leading to larger than expected glyphs in the UI. Additionally, these proper VS icons require theming, or else you can get black-on-black or other poor contrast scenarios. These changes add explicit dimensions to `Image`s that display glyphs from `IGlyphService`. It also uses `ThemedImageSourceConverter` to theme the images correctly. Sometimes this requires setting `ImageThemingUtilities.ImageBackgroundColor`. NOTE: `MoveStaticMembersDialog` is not themed, so I did not apply the changes necessary to theme the icon correctly.
…uction. (dotnet#76871) Fixes dotnet#76651. Fixes dotnet#75002. Related to dotnet#76842. Related to dotnet#76870.
enables publishing a package for the vscode net9 branch
…ce (dotnet#76935) In VS 17.14 (and previews of 17.13, but we are reverting for P5), the editor's `IGlyphService` implementation was improved to return images from `IVsImageService2` based on the appropriate moniker. This fixes several instances of blurry 16px icons throughout the IDE. Unfortunately, some WPF components failed to specify explicit `Image` dimensions, leading to larger than expected glyphs in the UI.  Additionally, these proper VS icons require theming, or else you can get black-on-black or other poor contrast scenarios. These changes add explicit dimensions to `Image`s that display glyphs from `IGlyphService`. It also uses `ThemedImageSourceConverter` to theme the images correctly. Sometimes this requires setting `ImageThemingUtilities.ImageBackgroundColor`. NOTE: `MoveStaticMembersDialog` is not themed, so I did not apply the changes necessary to theme the icon correctly.
…net#76894) * WIP: Reduce CPU costs under AnalyzerExecutor.ExecuteSyntaxNodeActions In the scrolling speedometer test, the Roslyn CodeAnalysis process shows about 25% of CPU spent in this method. Of that, a surprising amount of it (11.2%) is spent in ImmutableSegmentedDictionary.TryGetValue. Debugging through this code, it appears this is because that is called O(m x n) times where m is the number of nodes to analyze and n is the number of items in groupedActions.GroupedActionsByAnalyzer. Instead, add a hook into GroupedAnalyzerActions to allow a mapping of kind -> analyzers. This can be used by executeNodeActionsByKind to get a much quicker way to determine whether the analyzer can contribute for the node in question. Only publishing this early so Cyrus can take a peek, as I still need to do a bit of debugging around these changes. Once Cyrus and I think the changes have merit, I will create a test insertion and publish the speedometer results once those are available. Only if all that goes well will I promote this PR out of draft mode. * Use some existing helpers to create a dictionary with ImmutableArray values. * Early return to avoid the added array walk when not necessary * Pull in Cyrus's suggested tweaks around ToImmutableSegmentedDictionaryAndFree * ; --------- Co-authored-by: Cyrus Najmabadi <[email protected]>
dotnet-issue-labeler
bot
added
the
untriaged
cston
approved these changes
Jan 28, 2025
jjonescz
merged commit f0833b8
into
dotnet:features/PartialEventsCtors
45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #76859
I want to bring in #76871 before the next PR of the feature.