Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume mibc data from VSCode profiling runs in official builds #77044

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Feb 5, 2025

Should help resolve https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2283633/
 
We now produce mibc profiling data for the C# extension in a dnceng/internal pipeline that runs every night. This updates Roslyn to consume pass the mibc to crossgen when building the language server. This is adapted from similar support in devkit.

Test build - https://dnceng.visualstudio.com/internal/_build/results?buildId=2635982&view=results

Crossgen successfully runs in CI:
image

image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 5, 2025
@dibarbet dibarbet force-pushed the dev/dibarbet/vscode_mibc branch 2 times, most recently from 74dd752 to 9d49bf9 Compare February 5, 2025 01:46
@dibarbet dibarbet force-pushed the dev/dibarbet/vscode_mibc branch from 9d49bf9 to 6d3b13a Compare February 5, 2025 22:37
@dibarbet dibarbet marked this pull request as ready for review February 6, 2025 00:45
@dibarbet dibarbet requested review from a team as code owners February 6, 2025 00:45
@dibarbet dibarbet changed the title Consume mibc data from VSCode profiling runs Consume mibc data from VSCode profiling runs in official builds Feb 6, 2025
@dibarbet
Copy link
Member Author

dibarbet commented Feb 6, 2025

going to hold off merging this just a bit until the .net9 changes go through.

@dibarbet dibarbet merged commit 9f3c6eb into dotnet:main Feb 10, 2025
25 checks passed
@dibarbet dibarbet deleted the dev/dibarbet/vscode_mibc branch February 10, 2025 19:45
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Feb 10, 2025
@akhera99 akhera99 modified the milestones: Next, 17.14 P2 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants