Remove unnecessary lambda in diag service #77089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
reviewed
Feb 6, 2025
| project, | ||
| // Ensure we compute and return diagnostics for both the normal docs and the additional docs in this | ||
| // project if no specific document id was requested. | ||
| this.DocumentId != null ? [this.DocumentId] : [.. project.DocumentIds, .. project.AdditionalDocumentIds], |
There was a problem hiding this comment.
rather than having the documentId be nullable - would it be better if the API was modified to take in a set of documentIds as a required parameter? If we're updating the API to remove the getter anyway
There was a problem hiding this comment.
maybe. i need to fully internalize all callers. If it is really "give me the diags for a project" and "give me diags for a single doc", then yes i think the final internal api would be as you mention, with two public entrypoints. I'm still just trying to make small incremental changes to get tehre :)
right now though, i don't mind the apis looking like ProjectId projectId, DocumentId? documentId to represent both those cases through one api.
dibarbet
approved these changes
Feb 6, 2025
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.