Use common helper for diagnostics #77109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Feb 7, 2025
| stateSets.SelectAsArray(s => !s.IsHostAnalyzer, s => s.Analyzer), | ||
| stateSets.SelectAsArray(s => s.IsHostAnalyzer, s => s.Analyzer), | ||
| crashOnAnalyzerException, | ||
| cancellationToken); |
There was a problem hiding this comment.
just formatting. no other change. (though this makes it clear why it's ok to call into this method from the method below in the PR).
CyrusNajmabadi
commented
Feb 7, 2025
| // PERF: get analyzers that are not suppressed and marked as open file only | ||
| // this is perf optimization. we cache these result since we know the result. (no diagnostics) | ||
| var activeProjectAnalyzers = stateSets.SelectAsArray(s => !s.IsHostAnalyzer, s => s.Analyzer); | ||
| var activeHostAnalyzers = stateSets.SelectAsArray(s => s.IsHostAnalyzer, s => s.Analyzer); |
There was a problem hiding this comment.
doing the same filtering that the common helper does.
CyrusNajmabadi
force-pushed
the
diagHelper
branch
from
81ba94c to
9e30885
Compare
|
@dibarbet @JoeRobich ptal. |
dibarbet
approved these changes
Feb 7, 2025
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.