Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests in VMR #77179

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

NikolaMilosavljevic
Copy link
Member

Fixes #76960

Roslyn tests are failing in VMR with mismatched package version errors, i.e.:

C:\git\dotnet\src\roslyn\src\Compilers\Core\CodeAnalysisTest\Microsoft.CodeAnalysis.UnitTests.csproj : error NU1109: Detected package downgrade: Microsoft.TestPlatform.ObjectModel from 17.12.0 to centrally defined 17.5.0. Update the centrally managed package version to a higher version.  [C:\git\dotnet\src\roslyn\Roslyn.sln]
C:\git\dotnet\src\roslyn\src\Compilers\Core\CodeAnalysisTest\Microsoft.CodeAnalysis.UnitTests.csproj : error NU1109:  Microsoft.CodeAnalysis.UnitTests -> Microsoft.NET.Test.Sdk 17.12.0 -> Microsoft.TestPlatform.TestHost 17.12.0 -> Microsoft.TestPlatform.ObjectModel (>= 17.12.0)  [C:\git\dotnet\src\roslyn\Roslyn.sln]
C:\git\dotnet\src\roslyn\src\Compilers\Core\CodeAnalysisTest\Microsoft.CodeAnalysis.UnitTests.csproj : error NU1109:  Microsoft.CodeAnalysis.UnitTests -> Microsoft.TestPlatform.ObjectModel (>= 17.5.0) [C:\git\dotnet\src\roslyn\Roslyn.sln]

The fix is to explicitly set the version of Microsoft.NET.Test.Sdk that is consumed by arcade version that Roslyn uses.

@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner February 12, 2025 15:02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 12, 2025
@@ -142,8 +142,8 @@
-->
<PackageVersion Include="Microsoft.VisualStudio.LanguageServer.Client.Implementation" Version="17.10.72-preview" />
<PackageVersion Include="NuGet.ProjectModel" Version="6.8.0-rc.112" />
<PackageVersion Include="Microsoft.TestPlatform.TranslationLayer" Version="$(_MicrosoftTestPlatformVersion)" />
<PackageVersion Include="Microsoft.TestPlatform.ObjectModel" Version="$(_MicrosoftTestPlatformVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_MicrosoftTestPlatformVersion property seems to be unused now, should it be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, missed that - I'll send the update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with f252374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numerous failures while building roslyn tests in VMR
3 participants