-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tests in VMR #77179
Enable tests in VMR #77179
Conversation
@@ -142,8 +142,8 @@ | |||
--> | |||
<PackageVersion Include="Microsoft.VisualStudio.LanguageServer.Client.Implementation" Version="17.10.72-preview" /> | |||
<PackageVersion Include="NuGet.ProjectModel" Version="6.8.0-rc.112" /> | |||
<PackageVersion Include="Microsoft.TestPlatform.TranslationLayer" Version="$(_MicrosoftTestPlatformVersion)" /> | |||
<PackageVersion Include="Microsoft.TestPlatform.ObjectModel" Version="$(_MicrosoftTestPlatformVersion)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_MicrosoftTestPlatformVersion
property seems to be unused now, should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, missed that - I'll send the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with f252374
Fixes #76960
Roslyn tests are failing in VMR with mismatched package version errors, i.e.:
The fix is to explicitly set the version of
Microsoft.NET.Test.Sdk
that is consumed by arcade version that Roslyn uses.