Classify string fields with embedded languages if we can see their values passed to a StringSyntax api #77199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues passed to a StringSyntax api
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Feb 13, 2025
|
|
||
| var block = tokenParent.AncestorsAndSelf().FirstOrDefault(blockFacts.IsExecutableBlock); | ||
| if (block is null) | ||
| return false; | ||
|
|
||
| var localName = localSymbol.Name; | ||
| if (localName == "") | ||
| return false; |
There was a problem hiding this comment.
pulled into pattern match above.
CyrusNajmabadi
commented
Feb 13, 2025
| foreach (var descendent in statement.DescendantNodesAndSelf()) | ||
| { | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| if (CheckDescendants(localSymbol, semanticModel, statement, cancellationToken, out identifier)) |
There was a problem hiding this comment.
extracted into helper. we use it for the field case as well.
CyrusNajmabadi
commented
Feb 13, 2025
| @@ -1312,4 +1312,70 @@ void Goo() | |||
| Namespace("RegularExpressions"), | |||
There was a problem hiding this comment.
view with whitespace off.
JoeRobich
approved these changes
Feb 13, 2025
This was referenced Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77189