Partial events and constructors: public API #77202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
VSCode
Needs API Review
jjonescz
force-pushed
the
PartialEventsCtors-07-PublicApi
branch
from
118bb9a to
0c6c9aa
Compare
|
@cston and @RikkiGibson for reviews, thanks |
cston
reviewed
Feb 14, 2025
src/Compilers/CSharp/Portable/Symbols/PublicModel/EventSymbol.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Feb 17, 2025
cston
approved these changes
Feb 17, 2025
|
@RikkiGibson for a second review, thanks |
1 similar comment
|
@RikkiGibson for a second review, thanks |
RikkiGibson
reviewed
Feb 24, 2025
|
|
||
| Assert.NotEqual(defSymbol, implSymbol); | ||
| Assert.Same(implSymbol, defSymbol.PartialImplementationPart); | ||
| Assert.Same(defSymbol, implSymbol.PartialDefinitionPart); |
There was a problem hiding this comment.
nit: seems like it would be good to assert that the implSymbol.PartialImplementationPart is null, same with defSymbol.PartialDefinitionPart.
RikkiGibson
approved these changes
Feb 24, 2025
jjonescz
merged commit 65f15ca
into
dotnet:features/PartialEventsCtors
25 of 28 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #76859
Public API: resolves #77203