Switch TextDocumentState.GetTextVersionAsync to ValueTask to reduce allocations. #77213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uce allocations. The task creation from calling this method accounts for 34 MB (0.2%) of allocations in the CSharpEditingTests.Completion speedometer test. Going to run a test insertion to verify that this gets rid of the majority of these allocations before proceeding.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Was finally able to get a test insertion run after Ankita's PR validation fix https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/612409 Results look good, will update PR description and move out of draft status |
ToddGrun
changed the title
CyrusNajmabadi
approved these changes
Feb 20, 2025
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task creation from calling this method accounts for ~36 MB (0.2%) of allocations in the CSharpEditingTests.Completion speedometer test.
Results from speedometer run linked below (filtered to devenv;TypeTaskVersionStamp)
*** BEFORE ***
*** AFTER ***
