Mix the source generator version info into the dependent checksum we get for projects #77273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
approved these changes
Feb 19, 2025
| var transitiveDependencies = solution.GetProjectDependencyGraph().GetProjectsThatThisProjectTransitivelyDependsOn(this.ProjectState.Id); | ||
| // Calculate a checksum this project and for each dependent project that could affect semantics for this | ||
| // project. We order the projects so that we are resilient to the underlying in-memory graph structure | ||
| // changing this arbitrarily. We do not want that to cause us to change our semantic version.. Note: we |
There was a problem hiding this comment.
Suggested change
| // changing this arbitrarily. We do not want that to cause us to change our semantic version.. Note: we | |
| // changing this arbitrarily. We do not want that to cause us to change our semantic version. Note: we |
| // changing this arbitrarily. We do not want that to cause us to change our semantic version.. Note: we | ||
| // use the project filepath+name as a unique way to reference a project. This matches the logic in our | ||
| // persistence-service implementation as to how information is associated with a project. | ||
| var transitiveDependencies = solution.SolutionState.GetProjectDependencyGraph().GetProjectsThatThisProjectTransitivelyDependsOn(this.ProjectState.Id); |
There was a problem hiding this comment.
Asking a general question which doesn't need to impact this PR:
Is there a reason this gets the full transitive list versus just asking the immediate project references and mixing in their checksums, which would themselves depend on their immediate project references...etc? Are we going to be generating extra dependency graph entries here even though we don't need to?
There was a problem hiding this comment.
i have a followup pr that does that :)
| // changing this arbitrarily. We do not want that to cause us to change our semantic version.. Note: we | ||
| // use the project filepath+name as a unique way to reference a project. This matches the logic in our | ||
| // persistence-service implementation as to how information is associated with a project. | ||
| var transitiveDependencies = solution.SolutionState.GetProjectDependencyGraph().GetProjectsThatThisProjectTransitivelyDependsOn(this.ProjectState.Id); | ||
| var orderedProjectIds = transitiveDependencies.OrderBy(id => |
There was a problem hiding this comment.
Asking a general question which doesn't need to impact this PR:
Why do we sort this way versus just sorting by GUID or something?
There was a problem hiding this comment.
that would work as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For @dibarbet
David, consider taking this approach and mixing into your current PR around diagnostics + SG.