FB

dotnet · Aug 11, 2022 · 72ec834 · 72ec834
1 parent f5d7587
commit 72ec834
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 60 deletions.
diff --git a/...ativeaot/System.Private.CoreLib/src/Internal/Reflection/Core/Execution/ExecutionDomain.cs b/...ativeaot/System.Private.CoreLib/src/Internal/Reflection/Core/Execution/ExecutionDomain.cs
@@ -42,7 +42,7 @@ internal ExecutionDomain(ReflectionDomainSetup executionDomainSetup, ExecutionEn
         public Type GetType(string typeName, Func<AssemblyName, Assembly> assemblyResolver, Func<Assembly, string, bool, Type> typeResolver, bool throwOnError, bool ignoreCase, IList<string> defaultAssemblyNames)
         {
             if (typeName == null)
-                throw new ArgumentNullException();
+                throw new ArgumentNullException(nameof(typeName));
 
             if (typeName.Length == 0)
             {

diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/BindableAttributeTests.cs b/src/libraries/System.ComponentModel.TypeConverter/tests/BindableAttributeTests.cs
@@ -95,8 +95,6 @@ public void Default_Get_ReturnsExpected()
         {
             BindableAttribute attribute = BindableAttribute.Default;
             Assert.Same(attribute, BindableAttribute.Default);
-            Debug.Assert(object.ReferenceEquals(attribute, BindableAttribute.Default));
-            Debug.Assert(object.ReferenceEquals(attribute, BindableAttribute.No));
             Assert.Same(attribute, BindableAttribute.No);
 
             Assert.False(attribute.Bindable);

diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs b/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs
@@ -33,7 +33,6 @@ public void Ctor_String(Type installerType)
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/73723", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))]
         public void Ctor_NullTypeName_InstallerTypeThrowsArgumentNullException()
         {
             var attribute = new InstallerTypeAttribute((string)null);

diff --git a/...ystem.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj b/...ystem.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj
@@ -6,9 +6,6 @@
     <AssemblyVersion>9.9.9.9</AssemblyVersion>
     <TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
   </PropertyGroup>
-  <ItemGroup>
-    <RdXmlFile Include="default.rd.xml" />
-  </ItemGroup>
   <ItemGroup>
     <Compile Include="Drawing\ColorConverterTests.cs" />
     <Compile Include="Drawing\PointConverterTests.cs" />

diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.cs b/src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.cs
diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/XTypeDescriptionProviderTests.cs b/src/libraries/System.ComponentModel.TypeConverter/tests/XTypeDescriptionProviderTests.cs
@@ -12,7 +12,7 @@ namespace System.Xml.Linq.Tests
 {
     public class XTypeDescriptionProviderTests
     {
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNativeAot))]
         public void XAttributeValuePropertyDescriptor()
         {
             var xatt = new XAttribute("someAttribute", "someValue");
@@ -41,7 +41,7 @@ public void XAttributeValuePropertyDescriptor()
             Assert.Equal(newValue, xatt.Value);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNativeAot))]
         public void XElementAttributePropertyDescriptor()
         {
             var xel = new XElement("someElement");
@@ -117,7 +117,7 @@ public void XElementAttributePropertyDescriptor()
             Assert.True(valueChanged);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNativeAot))]
         public void XElementDescendantsPropertyDescriptor()
         {
             var xel = new XElement("someElement");
@@ -150,7 +150,7 @@ public void XElementDescendantsPropertyDescriptor()
             Assert.True(valueChanged);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNativeAot))]
         public void XElementElementPropertyDescriptor()
         {
             var xel = new XElement("someElement");
@@ -225,7 +225,7 @@ public void XElementElementPropertyDescriptor()
             Assert.True(valueChanged);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNativeAot))]
         public void XElementElementsPropertyDescriptor()
         {
             var xel = new XElement("someElement");
@@ -258,7 +258,7 @@ public void XElementElementsPropertyDescriptor()
             Assert.True(valueChanged);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNativeAot))]
         public void XElementValuePropertyDescriptor()
         {
             var xel = new XElement("someElement", "someValue");
@@ -292,7 +292,7 @@ public void XElementValuePropertyDescriptor()
             Assert.Equal(xel.Value, xelValPD.GetValue(xel));
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNativeAot))]
         public void XElementXmlPropertyDescriptor()
         {
             var xel = new XElement("someElement");

diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/default.rd.xml b/src/libraries/System.ComponentModel.TypeConverter/tests/default.rd.xml
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,7 +33,6 @@ public void Ctor_String(Type installerType) @@
             }
             [Fact]
-            [ActiveIssue("https://github.com/dotnet/runtime/issues/73723", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))]
             public void Ctor_NullTypeName_InstallerTypeThrowsArgumentNullException()
             {
                 var attribute = new InstallerTypeAttribute((string)null);
@@ Expand Down @@