Ensure generator removal target is for all TFMs

dotnet · Apr 7, 2023 · 9eab1ce · 9eab1ce
1 parent d4275bf
commit 9eab1ce
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/...soft.Extensions.Configuration.Binder/src/Microsoft.Extensions.Configuration.Binder.csproj b/...soft.Extensions.Configuration.Binder/src/Microsoft.Extensions.Configuration.Binder.csproj
@@ -37,12 +37,10 @@
 
   <PropertyGroup>
     <IncludeMultiTargetRoslynComponentTargets>false</IncludeMultiTargetRoslynComponentTargets>
+    <DisableNETStandardCompatErrors>true</DisableNETStandardCompatErrors>
   </PropertyGroup>
 
   <ItemGroup>
-    <Content Include="buildTransitive\$(MSBuildProjectName).*"
-             PackagePath="buildTransitive\netstandard2.0\;
-                          buildTransitive\$(NetCoreAppMinimum)\;
-                          buildTransitive\$(NetFrameworkMinimum)\" />
+    <Content Include="buildTransitive\$(PackageId).targets" PackagePath="buildTransitive\netstandard2.0\" />
   </ItemGroup>
 </Project>
diff --git a/...onfiguration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets b/...onfiguration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets
@@ -1,4 +1,4 @@
-<Project>
+<Project InitialTargets="NETStandardCompatError_Microsoft_Extensions_Configuration_Binder">
     <Target Name="_Microsoft_Extensions_Configuration_BinderRemoveAnalyzer" 
             Condition="'$(EnableConfigurationBindingGenerator)' != 'true'"
             AfterTargets="ResolvePackageDependenciesForBuild;ResolveNuGetPackageAssets">
@@ -7,4 +7,22 @@
             <Analyzer Remove="@(Analyzer->WithMetadataValue('NuGetPackageId', 'Microsoft.Extensions.Configuration.Binder'))" />
         </ItemGroup>
     </Target>
+
+    <!-- Only apply for [net4.6.1] and [netcoreapp2.0, net6.0) -->
+    <Target Name="NETStandardCompatError_Microsoft_Extensions_Configuration_Binder"
+          Condition="'$(SuppressTfmSupportBuildWarnings)' == '' AND
+          (
+            (
+                $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net4.6.1')) AND
+                !$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net4.6.2'))
+            )
+            OR
+            (
+                $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'netcoreapp2.0')) AND
+                !$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))
+            )
+          )
+          ">
+    <Warning Text="Microsoft.Extensions.Configuration.Binder doesn't support $(TargetFramework) and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set &lt;SuppressTfmSupportBuildWarnings&gt;true&lt;/SuppressTfmSupportBuildWarnings&gt; in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk." />
+  </Target>
 </Project>