Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossgen code removal tracking issue #54129

Closed
mangod9 opened this issue Jun 13, 2021 · 6 comments
Closed

Crossgen code removal tracking issue #54129

mangod9 opened this issue Jun 13, 2021 · 6 comments
Labels
area-crossgen2-coreclr tracking This issue is tracking the completion of other related issues.
Milestone

Comments

@mangod9
Copy link
Member

mangod9 commented Jun 13, 2021

The intent for this is to track changes as code for crossgen is removed. Epic for crossgen replacement: #43653.

First set of changes:

  1. Remove crossgen from build: exclude crossgen from build. #53458.
  2. Remove crossgen related test scripts: Remove crossgen from test build and run scripts #54348
  3. Remove more crossgen related files from building: removing more crossgen code from being built. #54458

We can add more as cleanup progresses.

@mangod9 mangod9 added area-crossgen2-coreclr tracking This issue is tracking the completion of other related issues. labels Jun 13, 2021
@mangod9 mangod9 added this to the 7.0.0 milestone Jun 13, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 13, 2021
@jkoritzinsky
Copy link
Member

@mangod9 does the existence of this tracking issue mean that the crossgen.exe removal was clean upstack and we can start removing more crossgen code?

@mangod9
Copy link
Member Author

mangod9 commented Jun 14, 2021

Not quite. It was created based on the ask here: #53458 (comment). Notice the milestone is .net 7 :). Will update this issue once we get clearance across repos, mostly post preview6 release at the earliest.

@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Jun 14, 2021
@mangod9
Copy link
Member Author

mangod9 commented Jun 14, 2021

For additional context we continue to find cases which need fixing as the removal change propagates across repos. Eg:
dotnet/sdk@f89440c
dotnet/installer#10888

@jkoritzinsky
Copy link
Member

That sounds good! Just keep this thread up to date for when code removal can commence. I know the whole interop team is looking forward to helping with the cleanup.

@AaronRobinsonMSFT
Copy link
Member

@mangod9 Is this issue the same as #53007?

@mangod9
Copy link
Member Author

mangod9 commented Jun 15, 2021

yeah guess we can roll this into #53007 if removing CROSSGEN_COMPILE would complete the cleanup for crossgen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-crossgen2-coreclr tracking This issue is tracking the completion of other related issues.
Projects
None yet
Development

No branches or pull requests

4 participants