[jitosr_stress_random] Failures in System.Text related tests

[jakobbotsch]

There seem to be widespread failures in System.Text related tests in the jitosr_stress_random runs: https://dev.azure.com/dnceng-public/public/_build/results?buildId=217773&view=results

Example failure on windows-release-x64: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-0dce5b8399ce429a95/System.Text.Encodings.Web.Tests/1/console.1cdfd228.log?helixlogtype=result

  Starting:    System.Text.Encodings.Web.Tests (parallel test collections = on, max threads = 4)
    System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple_Escaping [FAIL]
      Assert.Equal() Failure
                  ? (pos 2)
      Expected: \b
      Actual:   \by
                  ? (pos 2)
      Stack Trace:
        /_/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.Relaxed.cs(75,0): at System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple(String input, String expected)
        /_/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.Relaxed.cs(56,0): at System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple_Escaping()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(59,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

cc @AndyAyersMS

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-encoding
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There seem to be widespread failures in System.Text related tests in the jitosr_stress_random runs: https://dev.azure.com/dnceng-public/public/_build/results?buildId=217773&view=results

Example failure on windows-release-x64: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-0dce5b8399ce429a95/System.Text.Encodings.Web.Tests/1/console.1cdfd228.log?helixlogtype=result

  Starting:    System.Text.Encodings.Web.Tests (parallel test collections = on, max threads = 4)
    System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple_Escaping [FAIL]
      Assert.Equal() Failure
                  ? (pos 2)
      Expected: \b
      Actual:   \by
                  ? (pos 2)
      Stack Trace:
        /_/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.Relaxed.cs(75,0): at System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple(String input, String expected)
        /_/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.Relaxed.cs(56,0): at System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple_Escaping()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(59,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

cc @AndyAyersMS

Author:	jakobbotsch
Assignees:	-
Labels:	area-System.Text.Encoding, untriaged
Milestone:	-

[AndyAyersMS]

Probably from #83910

[AndyAyersMS]

Can repro; about 1100 OSR methods created.

Going to narrow this down by bisection via DOTNET_JitEnablePatchpointRange

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There seem to be widespread failures in System.Text related tests in the jitosr_stress_random runs: https://dev.azure.com/dnceng-public/public/_build/results?buildId=217773&view=results

Example failure on windows-release-x64: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-0dce5b8399ce429a95/System.Text.Encodings.Web.Tests/1/console.1cdfd228.log?helixlogtype=result

  Starting:    System.Text.Encodings.Web.Tests (parallel test collections = on, max threads = 4)
    System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple_Escaping [FAIL]
      Assert.Equal() Failure
                  ? (pos 2)
      Expected: \b
      Actual:   \by
                  ? (pos 2)
      Stack Trace:
        /_/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.Relaxed.cs(75,0): at System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple(String input, String expected)
        /_/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.Relaxed.cs(56,0): at System.Text.Encodings.Web.Tests.JavaScriptEncoderTests.JavaScriptEncode_Relaxed_StillEncodesForbiddenChars_Simple_Escaping()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(59,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

cc @AndyAyersMS

Author:	jakobbotsch
Assignees:	AndyAyersMS
Labels:	area-CodeGen-coreclr, test-failure
Milestone:	8.0.0

[AndyAyersMS]

Isolated one method where OSR causes problems:

2658: JIT compiled System.Text.Encodings.Web.DefaultJavaScriptEncoder+EscaperImplementation:EncodeUtf16(System.Text.Rune,System.Span`1[ushort]):int:this [Tier1-OSR @0x19, IL size=59, code size=68, hash=0x2131b33c]

Codegen diff between main and main before #83910.

;; before
IN0008: 000025 movzx    rdx, byte  ptr [V03 rsp+90H]

;; after
IN0008: 000025 mov      edx, dword ptr [V03 rsp+90H]

[AndyAyersMS]

Looks like small OSR locals that end up not getting allocated need to be normalize on load. We were getting this "for free" when we marked them as exposed.

[AndyAyersMS]

Change is simple. Reviewing diffs (which are a bit more extensive than I would have expected) and seeing if I can come up with a good regression test.